feat(api): query parameters to trigger events #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almostinf
reviewed
Jul 23, 2024
almostinf
reviewed
Jul 23, 2024
almostinf
reviewed
Jul 23, 2024
almostinf
reviewed
Jul 23, 2024
almostinf
reviewed
Jul 23, 2024
almostinf
reviewed
Jul 23, 2024
almostinf
reviewed
Jul 23, 2024
almostinf
reviewed
Jul 23, 2024
almostinf
reviewed
Jul 23, 2024
almostinf
reviewed
Jul 23, 2024
almostinf
reviewed
Jul 23, 2024
kissken
reviewed
Jul 25, 2024
kissken
reviewed
Jul 25, 2024
kissken
reviewed
Jul 25, 2024
kissken
reviewed
Jul 25, 2024
| func TestMetricProviderMiddleware(t *testing.T) { | ||
| Convey("checking correctness of parameter", t, func() { | ||
| responseWriter := httptest.NewRecorder() | ||
| defaultMetric := ".*" |
There was a problem hiding this comment.
у тебя вроде бы где-то была на такое публичная константа
There was a problem hiding this comment.
она не публичная, в handler
almostinf
reviewed
Jul 29, 2024
Tetrergeru
reviewed
Jul 29, 2024
Tetrergeru
reviewed
Jul 29, 2024
Tetrergeru
reviewed
Jul 29, 2024
Tetrergeru
reviewed
Jul 29, 2024
almostinf
reviewed
Jul 29, 2024
|
/build |
almostinf
previously approved these changes
Jul 30, 2024
almostinf
approved these changes
Aug 12, 2024
Tetrergeru
approved these changes
Aug 13, 2024
|
/build |
|
Build and push Docker images with tag: 2024-08-14.8560887 |
1 similar comment
|
Build and push Docker images with tag: 2024-08-14.8560887 |
almostinf
added a commit
that referenced
this pull request
Aug 14, 2024
This reverts commit 8560887.
almostinf
added a commit
that referenced
this pull request
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some query parameters to
/api/event/{trigger_id}Offered query parameters are:
from- start of time rangeto- end of time rangemetric- regular expression which will be used onNotificationEvent.Metricfieldstates- separated string of states, separator is','